Skip to content

ci(actionlint): ignore stale create-github-app-token input errors#755

Merged
kojiromike merged 4 commits into
openemr:masterfrom
kojiromike:actionlint-ignore-create-github-app-token
May 30, 2026
Merged

ci(actionlint): ignore stale create-github-app-token input errors#755
kojiromike merged 4 commits into
openemr:masterfrom
kojiromike:actionlint-ignore-create-github-app-token

Conversation

@kojiromike
Copy link
Copy Markdown
Member

Summary

actionlint ships pre-v3.1.0 bundled metadata for actions/create-github-app-token, so it wrongly rejects the current client-id input and demands the now-deprecated app-id. This adds a .github/actionlint.yaml that scopes an ignore to just that action's two error messages, keeping every other actionlint check active.

The errors silenced (across all workflows using client-id):

  • missing input "app-id" which is required by action "actions/create-github-app-token..."
  • input "client-id" is not defined in action "actions/create-github-app-token..."

Auto-discovered by both local runs and the reviewdog/action-actionlint CI job — no flag changes needed. Remove once the upstream fix lands: rhysd/actionlint#652

Test plan

  • actionlint CI job passes (no create-github-app-token errors, other checks intact)

actionlint ships pre-v3.1.0 metadata for actions/create-github-app-token,
so it wrongly rejects `client-id` and demands the deprecated `app-id`.
Scope an ignore to just that action until the upstream fix lands.

Assisted-by: Claude Code
Copilot AI review requested due to automatic review settings May 30, 2026 02:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an actionlint configuration workaround to suppress two known-false-positive errors for actions/create-github-app-token caused by actionlint’s stale bundled action metadata, while keeping all other actionlint checks enabled.

Changes:

  • Introduces .github/actionlint.yaml with scoped ignores for create-github-app-token’s deprecated app-id / new client-id input mismatch.
  • Limits the ignore scope to workflow files under .github/workflows/*.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/actionlint.yaml Outdated
Match `actions/create-github-app-token@<version>"` including the version
suffix and closing quote so the ignore can't accidentally match unrelated
messages sharing the prefix.

Assisted-by: Claude Code
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/actionlint.yaml Outdated
The paths filter only matched .github/actions/** and .github/workflows/**,
so edits to the new .github/actionlint.yaml config would not run the lint
job. Add the config to both push and pull_request paths.

Assisted-by: Claude Code
@kojiromike kojiromike requested a review from Copilot May 30, 2026 02:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

GitHub Actions accepts both extensions; scope the ignore glob to
*.{yml,yaml} so a future .yaml workflow using create-github-app-token
isn't silently excluded from the workaround.

Assisted-by: Claude Code
@kojiromike kojiromike merged commit bfac9be into openemr:master May 30, 2026
3 checks passed
@kojiromike kojiromike deleted the actionlint-ignore-create-github-app-token branch May 30, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants